New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Chromium 67 #13756
chore: Chromium 67 #13756
Conversation
77f9b07
to
30f8da9
Compare
155a8bd
to
32d3a1f
Compare
0a9eda4
to
10273f6
Compare
519a333
to
07ba5a5
Compare
37ea92e
to
b9ce625
Compare
22b5cd8
to
076972c
Compare
Will this PR be included in the final release of 3.0? |
@KoenLav this PR is intended for 4.0 |
@jkleinsc any rough idea of a timeline for 4.0? Or will this PR also be backported to 3.0? We're hoping for quite some performance improvements from this PR (when compared to 2.0) :) |
@KoenLav at this point there is no specific timeline for 4.0. Due to our adoption of semantic versioning, the upgrade to Chromium 67 will not be backported to 3.0. |
beae267
to
a355453
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks super close to being ready! 😁
Ideally widget delegates must outlive their widget, but since we manage the lifetime of native widget, allow the delegate to be destroyed when widget is destroyed. https://chromium-review.googlesource.com/c/chromium/src/+/977244
osr_render_widget_host_view.cc:1150:12: error: [chromium-style] auto variable type must not deduce to a raw pointer type. (cherry picked from commit cc8e4ef)
(cherry picked from commit da2b2e7)
* build: [m67] enable widevine support * fix: remove plugin cache reset hack It was added in (#8907) to make widevine cdm shows up in navigator.plugins, since widevine support is no longer enabled by a plugin it can be removed safely.
efbe869
to
f76a8c7
Compare
Release Notes Persisted
|
BREAKING CHANGE
Chromium 67.0.3396.99
Node.js 10.6.0
Fixes #13683.
Project Board https://github.com/electron/electron/projects/11
PR to libcc electron/libchromiumcontent#607
notes: Use Chromium 67.